sonata-project / SonataMediaBundle

Symfony SonataMediaBundle
https://docs.sonata-project.org/projects/SonataMediaBundle
MIT License
451 stars 495 forks source link

No icons on buttons when creating new media #761

Closed bigfoot90 closed 9 years ago

bigfoot90 commented 9 years ago

I'm using SonataAdminBundle 2.3 and SonataMediaBundle 2.3 There are not icons on buttons when creating an new media. schermata del 2015-05-01 23 57 16

Pop-Code commented 9 years ago

same here, this is due to base64 encoded images in src.

lightglitch commented 9 years ago

The problem is that the core bundle always forces an image (https://github.com/sonata-project/SonataCoreBundle/blob/master/Model/Metadata.php#L60) and the class icon is ignored (https://github.com/sonata-project/SonataMediaBundle/blob/master/Resources/views/MediaAdmin/select_provider.html.twig#L32) @rande a quick fix would be nice

lightglitch commented 9 years ago

I's already fixed on master but not on stable. :(

@rande Just added #769 can you make a quick stable release?

hoannv commented 9 years ago

same issue: #778

soullivaneuh commented 9 years ago

It's already fixed on master but not on stable. :( @rande Just added #769 can you make a quick stable release?

@lightglitch In which PR is already fixed on master? Could you cherry-pick it for a PR instead of creating a new one? Thanks.

lightglitch commented 9 years ago

@Soullivaneuh the commit that fixes this is https://github.com/sonata-project/SonataMediaBundle/commit/01a776d86299e285cf91b34d9e2b6140db9c6e6d you can cherry-pick it and merge it.

soullivaneuh commented 9 years ago

@lightglitch done here: https://github.com/sonata-project/SonataMediaBundle/commit/7e10c0ea67f38583486e666694dfb08376ef1376

Stable release coming soon.

soullivaneuh commented 9 years ago

https://github.com/sonata-project/SonataMediaBundle/releases/tag/2.3.3