search

sonata-project / SonataNewsBundle

[Abandoned] Symfony SonataNewsBundle
https://docs.sonata-project.org/projects/SonataNewsBundle
MIT License
151 stars 131 forks source link

Remove deprecated ReST API with dependencies #780

Closed wbloszyk closed 2 years ago

wbloszyk commented 2 years ago

Subject

Remove ReST API with dependencies and update routing with tests. Remove DatagridBundle with replace Pager by custom Pager (to allow use news without AdminBundle)

I am targeting this branch, because this should be done in unstable branch.

wbloszyk commented 2 years ago

You should try to remove datagrid bundle too.

I think about it too. In NewsBundle we use pagination in frontend. We can remove datagrid bundle in favor of KnpPaginationBundle. I will wait with it for now.

VincentLanglet commented 2 years ago

You should try to remove datagrid bundle too.

I think about it too. In NewsBundle we use pagination in frontend. We can remove datagrid bundle in favor of KnpPaginationBundle. I will wait with it for now.

The DatagridBundle pagination was supposed to be only used for API.

For frontend, there is already a Pager/Datagrid class in the AdminBundle (and his persistence bundle), made for this.

wbloszyk commented 2 years ago

Ready to review. PHPStan and Psalm will added after merge #779 to 3.x and merge it to 4.x.

VincentLanglet commented 2 years ago

Thanks