search

sonata-project / SonataPageBundle

This bundle provides a Site and Page management through container and block services
https://docs.sonata-project.org/projects/SonataPageBundle
MIT License
219 stars 210 forks source link

Problem with Internationalized routing #1206

Closed haivala closed 3 years ago

haivala commented 4 years ago

Environment

Dockerized linux Symfony project

Sonata packages

$ composer show --latest 'sonata-project/*'
sonata-project/admin-bundle              3.76.0 3.76.0 The missing Symfony Admin Generator
sonata-project/block-bundle              3.21.0 4.3.0  Symfony SonataBlockBundle
sonata-project/cache                     1.1.1  2.0.1  Cache library
sonata-project/cache-bundle              2.4.2  3.2.1  This bundle provides caching services
sonata-project/classification-bundle     3.13.2 3.13.2 Symfony SonataClassificationBundle
sonata-project/datagrid-bundle           2.5.0  3.2.0  Symfony SonataDatagridBundle
sonata-project/doctrine-extensions       1.9.1  1.9.1  Doctrine2 behavioral extensions
sonata-project/doctrine-orm-admin-bundle 3.23.0 3.23.0 Symfony Sonata / Integrate Doctrine ORM in...
sonata-project/easy-extends-bundle       2.5.0  2.5.0  Symfony SonataEasyExtendsBundle
sonata-project/exporter                  2.3.0  2.3.0  Lightweight Exporter library
sonata-project/form-extensions           1.6.0  1.6.0  Symfony form extensions
sonata-project/formatter-bundle          4.2.0  4.2.0  Symfony SonataFormatterBundle
sonata-project/media-bundle              3.27.0 3.27.0 Symfony SonataMediaBundle
sonata-project/notification-bundle       3.9.0  3.10.0 Symfony SonataNotificationBundle
sonata-project/page-bundle               3.19.0 3.19.0 This bundle provides a Site and Page manag...
sonata-project/seo-bundle                2.12.0 2.12.0 Symfony SonataSeoBundle
sonata-project/timeline-bundle           3.6.0  3.6.0  Integrates SpyTimelineBundle into Sonata
sonata-project/translation-bundle        2.6.0  2.6.0  SonataTranslationBundle
sonata-project/twig-extensions           1.4.1  1.4.1  Sonata twig extensions
sonata-project/user-bundle               4.8.0  4.8.0  Symfony SonataUserBundle

Symfony packages

$ composer show --latest 'symfony/*'
symfony/asset                      v4.4.13 v5.1.5  Symfony Asset Component
symfony/cache                      v5.1.5  v5.1.5  Symfony Cache component with PSR-6, PSR-16, and tags
symfony/cache-contracts            v2.2.0  v2.2.0  Generic abstractions related to caching
symfony/config                     v4.4.13 v5.1.5  Symfony Config Component
symfony/console                    v4.4.13 v5.1.5  Symfony Console Component
symfony/debug                      v4.4.13 v4.4.13 Symfony Debug Component
symfony/debug-bundle               v5.1.5  v5.1.5  Symfony DebugBundle
symfony/debug-pack                 v1.0.8  v1.0.8  A debug pack for Symfony projects
symfony/dependency-injection       v4.4.13 v5.1.5  Symfony DependencyInjection Component
symfony/deprecation-contracts      v2.2.0  v2.2.0  A generic function and convention to trigger deprecation notices
symfony/doctrine-bridge            v4.4.13 v5.1.5  Symfony Doctrine Bridge
symfony/dotenv                     v4.4.13 v5.1.5  Registers environment variables from a .env file
symfony/error-handler              v4.4.13 v5.1.5  Symfony ErrorHandler Component
symfony/event-dispatcher           v4.4.13 v5.1.5  Symfony EventDispatcher Component
symfony/event-dispatcher-contracts v1.1.9  v2.2.0  Generic abstractions related to dispatching event
symfony/expression-language        v4.4.13 v5.1.5  Symfony ExpressionLanguage Component
symfony/filesystem                 v4.4.13 v5.1.5  Symfony Filesystem Component
symfony/finder                     v4.4.13 v5.1.5  Symfony Finder Component
symfony/flex                       v1.9.4  v1.9.4  Composer plugin for Symfony
symfony/form                       v4.4.13 v5.1.5  Symfony Form Component
symfony/framework-bundle           v4.4.13 v5.1.5  Symfony FrameworkBundle
symfony/http-client                v4.4.13 v5.1.5  Symfony HttpClient component
symfony/http-client-contracts      v2.2.0  v2.2.0  Generic abstractions related to HTTP clients
symfony/http-foundation            v4.4.13 v5.1.5  Symfony HttpFoundation Component
symfony/http-kernel                v4.4.13 v5.1.5  Symfony HttpKernel Component
symfony/inflector                  v5.1.5  v5.1.5  Symfony Inflector Component
symfony/intl                       v5.1.5  v5.1.5  A PHP replacement layer for the C intl extension that includes additional data from the ICU library.
symfony/maker-bundle               v1.21.1 v1.21.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code.
symfony/mime                       v5.1.5  v5.1.5  A library to manipulate MIME messages
symfony/monolog-bridge             v4.4.13 v5.1.5  Symfony Monolog Bridge
symfony/monolog-bundle             v3.5.0  v3.5.0  Symfony MonologBundle
symfony/options-resolver           v4.4.13 v5.1.5  Symfony OptionsResolver Component
symfony/orm-pack                   v1.2.0  v2.0.0  A pack for the Doctrine ORM
symfony/polyfill-ctype             v1.18.1 v1.18.1 Symfony polyfill for ctype functions
symfony/polyfill-iconv             v1.18.1 v1.18.1 Symfony polyfill for the Iconv extension
symfony/polyfill-intl-grapheme     v1.18.1 v1.18.1 Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-icu          v1.18.1 v1.18.1 Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn          v1.18.1 v1.18.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer   v1.18.1 v1.18.1 Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring          v1.18.1 v1.18.1 Symfony polyfill for the Mbstring extension
symfony/polyfill-php70             v1.18.1 v1.18.1 Symfony polyfill backporting some PHP 7.0+ features to lower PHP versions
symfony/polyfill-php72             v1.18.1 v1.18.1 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73             v1.18.1 v1.18.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/polyfill-php80             v1.18.1 v1.18.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions
symfony/process                    v4.4.13 v5.1.5  Symfony Process Component
symfony/profiler-pack              v1.0.5  v1.0.5  A pack for the Symfony web profiler
symfony/property-access            v4.4.13 v5.1.5  Symfony PropertyAccess Component
symfony/routing                    v4.4.13 v5.1.5  Symfony Routing Component
symfony/security-acl               v3.1.0  v3.1.0  Symfony Security Component - ACL (Access Control List)
symfony/security-bundle            v4.4.13 v5.1.5  Symfony SecurityBundle
symfony/security-core              v4.4.13 v5.1.5  Symfony Security Component - Core Library
symfony/security-csrf              v5.1.5  v5.1.5  Symfony Security Component - CSRF Library
symfony/security-guard             v4.4.13 v5.1.5  Symfony Security Component - Guard
symfony/security-http              v4.4.13 v5.1.5  Symfony Security Component - HTTP Integration
symfony/service-contracts          v2.2.0  v2.2.0  Generic abstractions related to writing services
symfony/stopwatch                  v5.1.5  v5.1.5  Symfony Stopwatch Component
symfony/string                     v5.1.5  v5.1.5  Symfony String component
symfony/swiftmailer-bundle         v3.4.0  v3.4.0  Symfony SwiftmailerBundle
symfony/templating                 v4.4.13 v5.1.5  Symfony Templating Component
symfony/translation                v4.4.13 v5.1.5  Symfony Translation Component
symfony/translation-contracts      v2.2.0  v2.2.0  Generic abstractions related to translation
symfony/twig-bridge                v4.4.13 v5.1.5  Symfony Twig Bridge
symfony/twig-bundle                v4.4.13 v5.1.5  Symfony TwigBundle
symfony/validator                  v4.4.13 v5.1.5  Symfony Validator Component
symfony/var-dumper                 v5.1.5  v5.1.5  Symfony mechanism for exploring and dumping PHP variables
symfony/var-exporter               v5.1.5  v5.1.5  A blend of var_export() + serialize() to turn any serializable data structure to plain PHP code
symfony/web-profiler-bundle        v5.0.11 v5.1.5  Symfony WebProfilerBundle
symfony/webpack-encore-bundle      v1.7.3  v1.7.3  Integration with your Symfony app & Webpack Encore!
symfony/yaml                       v4.4.13 v5.1.5  Symfony Yaml Component

PHP version

$ php -v
PHP 7.4.2 (cli) (built: Jan 24 2020 07:18:03) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.2, Copyright (c), by Zend Technologies

Subject

I have $page = $cms->retrieve()->getCurrentPage() in my dynamic page controller and it was working fine. Then I tried to use this: https://symfony.com/blog/new-in-symfony-4-1-internationalized-routing and now the it does not work

Steps to reproduce

  1. make dynamic controller with internationalized routing
  2. use Sonata\PageBundle\CmsManager\CmsManagerSelector;
  3. update core routes and make snapshots
  4. try to access the $currentpage

Expected results

$currentPage exists https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/CmsManager/BaseCmsPageManager.php#L30

Actual results

$currentPage is null and trying to access the dynamic page gives this error: Sonata Project - Internal Error No page instance available for the url, run the sonata:page:update-core-routes and sonata:page:create-snapshots commands

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

haivala commented 3 years ago

basically this means that the pageBundle does not support dot route name notation for lang