Closed eerison closed 2 years ago
It would be nice to know how did you get that errors (for 1 and 3, the second one is in the process of being fixed), because they have some test that pass without problem.
It would be nice to know how did you get that errors (for 1 and 3, the second one is in the process of being fixed), because they have some test that pass without problem.
I just tried to add those blocks in composer page, and the ajax response return those errors
But you pass any special option to those block (or you miss yo add some required parameter)?
If you fill correctly the data, do they work?
But you pass any special option to those block (or you miss yo add some required parameter)?
If you fill correctly the data, do they work?
I fill out all required parameters.
If you fill correctly the data, do they work?
what do you mean the correctly data? fill all fields?
https://user-images.githubusercontent.com/6358755/188569002-891ca7a4-fa62-4c3e-9270-d6753a064776.mov
Hey @jordisala1991 does it help you with Shared block
?
Screen.Recording.2022-09-06.at.09.06.00.mov Hey @jordisala1991 does it help you with
Shared block
?
Yes, it helps. I see, we do not use the interaction with javascript on the tests for this specific use case, that's why I think we didn't spot the problem.
I see, in this case should we test the sub request directly?
I see, in this case should we test the sub request directly?
not sure tbh, too many bugs, until I fix the ones I am working on, I can't work on more π
well I do not use any of those blocks π, But I guess the share block are the most important one!
should we invest time only in this one and if someone else use the others 2 blocks provide a PR?
Ok Just to inform you in 4.x branch children page core is not crashing anymore, It doesn't appear any error, but I can't see any effect in my page π
Ok Just to inform you in 4.x branch children page core is not crashing anymore, It doesn't appear any error, but I can't see any effect in my page π
It should show a list of children pages of the selected one, it does not work?
Ok Just to inform you in 4.x branch children page core is not crashing anymore, It doesn't appear any error, but I can't see any effect in my page π
It should show a list of children pages of the selected one, it does not work?
hmmmm I can test it :)
it is crashing if you select a page and update the block with Unable to retrieve the page
in composer and in frontend
it is crashing if you select a page and update the block with
Unable to retrieve the page
in composer and in frontend
I'm comparing between 3.x and 4.x, I'll try to reproduce your bug thanks for the info @haivala
Nice Job @jordisala1991 π₯³
When I'm trying to use the page blocks, some of them are crashing the page
Blocks
Chieldren page core
Breadcrumb
Related issue: https://github.com/sonata-project/SonataSeoBundle/issues/685 ``` RuntimeException: The block "sonata.page.block.breadcrumb" must implement Sonata\BlockBundle\Block\Service\EditableBlockService at vendor/sonata-project/page-bundle/src/Admin/BlockAdmin.php:221 at Sonata\PageBundle\Admin\BlockAdmin->configureBlockFields(object(FormMapper), object(SonataPageBlock)) (vendor/sonata-project/page-bundle/src/Admin/BlockAdmin.php:179) at Sonata\PageBundle\Admin\BlockAdmin->configureFormFields(object(FormMapper)) (vendor/sonata-project/admin-bundle/src/Admin/AbstractAdmin.php:819) at Sonata\AdminBundle\Admin\AbstractAdmin->defineFormBuilder(object(FormBuilder)) (vendor/sonata-project/admin-bundle/src/Admin/AbstractAdmin.php:799) at Sonata\AdminBundle\Admin\AbstractAdmin->getFormBuilder() (vendor/sonata-project/admin-bundle/src/Admin/AbstractAdmin.php:2522) at Sonata\AdminBundle\Admin\AbstractAdmin->buildForm() (vendor/sonata-project/admin-bundle/src/Admin/AbstractAdmin.php:871) at Sonata\AdminBundle\Admin\AbstractAdmin->getForm() (vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php:571) at Sonata\AdminBundle\Controller\CRUDController->createAction(object(Request)) (vendor/sonata-project/page-bundle/src/Controller/BlockAdminController.php:102) at Sonata\PageBundle\Controller\BlockAdminController->createAction(object(Request)) (vendor/symfony/http-kernel/HttpKernel.php:159) at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1) (vendor/symfony/http-kernel/HttpKernel.php:81) at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true) (vendor/symfony/http-kernel/Kernel.php:201) at Symfony\Component\HttpKernel\Kernel->handle(object(Request)) (public/index.php:29) ```
Shared block
``` Twig\Error\RuntimeError: An exception has been thrown during the rendering of a template ("Parameter "id" for route "admin_app_sonatapagepage_sonatapageblock_edit" must match "[^/]++" ("" given) to generate a corresponding URL."). at vendor/sonata-project/admin-bundle/src/Resources/views/Helper/short-object-description.html.twig:3 at Twig\Template->displayWithErrorHandling(array('admin' => object(BlockAdmin), 'description' => 'Test A ~ #9', 'object' => object(SonataPageBlock), 'link_parameters' => array(), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array()) (vendor/twig/twig/src/Template.php:367) at Twig\Template->display(array('admin' => object(BlockAdmin), 'description' => 'Test A ~ #9', 'object' => object(SonataPageBlock), 'link_parameters' => array())) (vendor/twig/twig/src/Template.php:379) at Twig\Template->render(array('admin' => object(BlockAdmin), 'description' => 'Test A ~ #9', 'object' => object(SonataPageBlock), 'link_parameters' => array()), array()) (vendor/twig/twig/src/TemplateWrapper.php:40) at Twig\TemplateWrapper->render(array('admin' => object(BlockAdmin), 'description' => 'Test A ~ #9', 'object' => object(SonataPageBlock), 'link_parameters' => array())) (vendor/twig/twig/src/Environment.php:277) at Twig\Environment->render('@SonataAdmin/Helper/short-object-description.html.twig', array('admin' => object(BlockAdmin), 'description' => 'Test A ~ #9', 'object' => object(SonataPageBlock), 'link_parameters' => array())) (vendor/sonata-project/admin-bundle/src/Action/GetShortObjectDescriptionAction.php:84) at Sonata\AdminBundle\Action\GetShortObjectDescriptionAction->__invoke(object(Request)) (vendor/symfony/http-kernel/HttpKernel.php:159) at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1) (vendor/symfony/http-kernel/HttpKernel.php:81) at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true) (vendor/symfony/http-kernel/Kernel.php:201) at Symfony\Component\HttpKernel\Kernel->handle(object(Request)) (public/index.php:29) ```