search

sonata-project / SonataPageBundle

This bundle provides a Site and Page management through container and block services
https://docs.sonata-project.org/projects/SonataPageBundle
MIT License
218 stars 209 forks source link

Switch cocur/slugify to symfony/string #1713

Closed eerison closed 1 month ago

eerison commented 1 year ago

Switch cocur/slugify to symfony/string

in order to use more symfony packages and keep this repo using the same dependencies as admin bundle

I suggest we change slugify to symfony/string!

in case it makes sense, then I will try to do it :D

VincentLanglet commented 1 year ago

in case it makes sense, then I will try to do it :D

Sure it make sense ; but I dunno if we'll be able to drop the dependency in a BC way.

Pr is opened.

eerison commented 1 year ago

Yeah, we need to keep the dependency in 4.x and remove in 5.x only.

We need the both dependencies to keep BC compatibility

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

haivala commented 1 month ago

@eerison Any chance you could finish this?

eerison commented 1 month ago

Hello @haivala

unfortunately I am without free time :/