search

sonata-project / SonataPageBundle

This bundle provides a Site and Page management through container and block services
https://docs.sonata-project.org/projects/SonataPageBundle
MIT License
216 stars 209 forks source link

SiteSelector use isRouteUriDecorable instead of isRequestDecorable #1762

Open Haniki opened 3 months ago

Haniki commented 3 months ago

Feature Request

I see in BaseSiteSelector that we use the isRouteUriDecorable method in the onKernelRequest method.

https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Site/BaseSiteSelector.php#L54-L56

Shouldn't we use the isRequestDecorable method instead ? https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/CmsManager/DecoratorStrategy.php#L67

Without this, only the ignore_uri_patterns config is considered, and the ignore_route_patterns and the ignore_routes are ignored.