Missing css in tree view

loconox commented 9 years ago

In the last commit on branch master. The page tree in the admin section of the page bundle, the css disappeared.

Possible solution : I think the the file sonata-page.back.css is missing from the file tree.html.twig

loconox commented 9 years ago

Btw, I think the css and js, sonata-page.back.css and sonata-page.back.js is probably also missing from the vue compose.html.twig

meyerbaptiste commented 9 years ago

Now you need to import assets from the configuration of SonataAdminBundle:

sonata_admin:
    assets:
        stylesheets:
            - bundles/sonataadmin/vendor/bootstrap/dist/css/bootstrap.min.css
            - bundles/sonataadmin/vendor/AdminLTE/css/font-awesome.min.css
            - bundles/sonataadmin/vendor/AdminLTE/css/ionicons.min.css
            - bundles/sonataadmin/vendor/AdminLTE/css/AdminLTE.css
            - bundles/sonatacore/vendor/eonasdan-bootstrap-datetimepicker/build/css/bootstrap-datetimepicker.min.css
            - bundles/sonataadmin/vendor/jqueryui/themes/base/jquery-ui.css
            - bundles/sonataadmin/vendor/select2/select2.css
            - bundles/sonataadmin/vendor/select2/select2-bootstrap.css
            - bundles/sonataadmin/vendor/x-editable/dist/bootstrap3-editable/css/bootstrap-editable.css
            - bundles/sonataadmin/css/styles.css
            - bundles/sonataadmin/css/layout.css
            - bundles/sonatapage/sonata-page.back.min.css

        javascripts:
            - bundles/sonataadmin/vendor/jquery/dist/jquery.min.js
            - bundles/sonataadmin/vendor/jquery.scrollTo/jquery.scrollTo.min.js
            - bundles/sonatacore/vendor/moment/min/moment.min.js
            - bundles/sonataadmin/vendor/bootstrap/dist/js/bootstrap.min.js
            - bundles/sonatacore/vendor/eonasdan-bootstrap-datetimepicker/build/js/bootstrap-datetimepicker.min.js
            - bundles/sonataadmin/vendor/jqueryui/ui/minified/jquery-ui.min.js
            - bundles/sonataadmin/vendor/jqueryui/ui/minified/i18n/jquery-ui-i18n.min.js
            - bundles/sonataadmin/jquery/jquery.form.js
            - bundles/sonataadmin/jquery/jquery.confirmExit.js
            - bundles/sonataadmin/vendor/x-editable/dist/bootstrap3-editable/js/bootstrap-editable.min.js
            - bundles/sonataadmin/vendor/select2/select2.min.js
            - bundles/sonataadmin/App.js
            - bundles/sonataadmin/Admin.js
            - bundles/sonatapage/sonata-page.back.min.js

loconox commented 9 years ago

Well, that's not very clear. No documentation provides an exhaustive list of assets files. PageBundle don't even mentions sonata-page.back.min.[js|css]. If those files are needed for the AdminBundle to work in a default configuration, maybe include them at least in the DependencyInjection would be nice ? And btw, some files have been move to CoreBundle :

sonata_admin:
    assets:
        stylesheets:
            - bundles/sonatacore/vendor/bootstrap/dist/css/bootstrap.min.css
            - bundles/sonatacore/vendor/components-font-awesome/css/font-awesome.min.css
            - bundles/sonatacore/vendor/ionicons/css/ionicons.min.css
            - bundles/sonataadmin/vendor/AdminLTE/css/AdminLTE.css
            - bundles/sonatacore/vendor/eonasdan-bootstrap-datetimepicker/build/css/bootstrap-datetimepicker.min.css
            - bundles/sonataadmin/vendor/jqueryui/themes/base/jquery-ui.css
            - bundles/sonatacore/vendor/select2/select2.css
            - bundles/sonatacore/vendor/select2/select2-bootstrap.css
            - bundles/sonataadmin/vendor/x-editable/dist/bootstrap3-editable/css/bootstrap-editable.css
            - bundles/sonataadmin/css/styles.css
            - bundles/sonataadmin/css/layout.css
            - bundles/sonataadmin/css/tree.css
            - bundles/sonatapage/sonata-page.back.min.css

        javascripts:
            - bundles/sonatacore/vendor/jquery/dist/jquery.min.js
            - bundles/sonataadmin/vendor/jquery.scrollTo/jquery.scrollTo.min.js
            - bundles/sonatacore/vendor/moment/min/moment.min.js
            - bundles/sonatacore/vendor/bootstrap/dist/js/bootstrap.min.js
            - bundles/sonatacore/vendor/eonasdan-bootstrap-datetimepicker/build/js/bootstrap-datetimepicker.min.js
            - bundles/sonataadmin/vendor/jqueryui/ui/minified/jquery-ui.min.js
            - bundles/sonataadmin/vendor/jqueryui/ui/minified/i18n/jquery-ui-i18n.min.js
            - bundles/sonataadmin/jquery/jquery.form.js
            - bundles/sonataadmin/jquery/jquery.confirmExit.js
            - bundles/sonataadmin/vendor/x-editable/dist/bootstrap3-editable/js/bootstrap-editable.min.js
            - bundles/sonatacore/vendor/select2/select2.min.js
            - bundles/sonataadmin/App.js
            - bundles/sonataadmin/Admin.js
            - bundles/sonataadmin/treeview.js
            - bundles/sonatapage/sonata-page.back.min.js

meyerbaptiste commented 9 years ago

Yes sorry I was not in the master branch for SonataAdminBundle so bad assets...

sonata-page.back.min.[js|css] files are mentioned in the documentation of installation.

You can have an exhaustive list of assets files with the command php app/console config:dump-reference sonata_admin.

:+1: for the DependencyInjection.

cc @plouc

loconox commented 9 years ago

On branch master. I come back here to notice that the file Configuration.php still includes : 'bundles/sonataadmin/vendor/bootstrap/dist/css/bootstrap.min.css', 'bundles/sonataadmin/vendor/jquery/dist/jquery.min.js', but I think should include 'bundles/sonatacore/vendor/bootstrap/dist/css/bootstrap.min.css', 'bundles/sonatacore/vendor/jquery/dist/jquery.min.js',

OskarStark commented 8 years ago

@loconox what is the output of composer show -i | grep sonata ?

loconox commented 8 years ago

I'm sorry, I'm not using PageBundle anymore on my project.

OskarStark commented 8 years ago

@dunglas thank you for your help :+1:

i will close this issue

sonata-project / SonataPageBundle

Missing css in tree view #422