sonata-project / SonataSeoBundle

Symfony SonataSeoBundle
https://docs.sonata-project.org/projects/SonataSeoBundle
MIT License
136 stars 90 forks source link

[RFC] Remove twitter / facebook / pinterest blocks #519

Closed core23 closed 3 years ago

core23 commented 3 years ago

To reduce the complexity and sharpen the focus of this bundle, we should split(?) this bundle:

BlockBundle

SeoBundle

SocialBundle

core23 commented 3 years ago

This could solve this https://github.com/sonata-project/SonataSeoBundle/pull/516

wbloszyk commented 3 years ago

Great idea.

IMHO we should move SocialBlocks directly to BlockBundle(3.x and 4.x with conflict to previus version), becouse we have other blocks there which are not depends on other bundle (like MenuBlockService) . Then we can remove BlockBundle dependency and add it to sugestion in SeoBundle. So it will depends on user which version of BlockBundle want to use.

OskarStark commented 3 years ago

Or we can create a social block bundle?

wbloszyk commented 3 years ago

Or we can create a social block bundle?

It depends what we want:

Create bundle only for few blocks have no sense, but for other feature I vote for yes.

core23 commented 3 years ago

Create bundle only for few blocks have no sense, but for other feature I vote for yes.

It depends 😆 Some social blocks require other components (e.g. http client) which are only needed for a bunch of classes. Most classes don't need this client.

We could solve this by making the http client an optional dependency. I'm not a big fan of optional dependencies (anymore), because they can cause troubles when composer tries to determine the needed dependencies. We need to add require-dev and conflict dependencies to make sure that the optional dependency will always work.

Smaller projects require more maintenance work (in theory) but should require less work when releasing new major versions.

OskarStark commented 3 years ago

I would love to go to monorepo 🤣😳

core23 commented 3 years ago

I would love to go to monorepo 🤣😳

Can you do this? 😄

OskarStark commented 3 years ago

Not so much time right now and no experience... 😬

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.