search

sonata-project / SonataTranslationBundle

SonataTranslationBundle
https://docs.sonata-project.org/projects/SonataTranslationBundle
MIT License
77 stars 68 forks source link

global language switcher uses non-existing twig filter 'language' #327

Closed BigBadBassMan closed 4 years ago

BigBadBassMan commented 4 years ago

Environment

Sonata packages

$ composer show --latest 'sonata-project/*'
sonata-project/admin-bundle              3.61.0             3.61.0             The missing Symfony Admin Generator
sonata-project/block-bundle              3.18.4             4.1.0              Symfony SonataBlockBundle
sonata-project/cache                     2.0.1              2.0.1              Cache library
sonata-project/core-bundle               3.18.0             3.18.0             Symfony SonataCoreBundle (abandoned)
sonata-project/datagrid-bundle           2.5.0              3.1.1              Symfony SonataDatagridBundle
sonata-project/doctrine-extensions       1.5.1              1.5.1              Doctrine2 behavioral extensions
sonata-project/doctrine-orm-admin-bundle 3.14.0             3.14.0             Symfony Sonata / Integrate Doctrine ORM into the SonataAdminBundle
sonata-project/easy-extends-bundle       2.5.0              2.5.0              Symfony SonataEasyExtendsBundle
sonata-project/exporter                  2.1.0              2.1.0              Lightweight Exporter library
sonata-project/formatter-bundle          4.1.3              4.1.3              Symfony SonataFormatterBundle
sonata-project/intl-bundle               2.7.0              2.7.0              Symfony SonataIntlBundle
sonata-project/translation-bundle        dev-master e9d72db dev-master e9d72db SonataTranslationBundle
sonata-project/user-bundle               4.5.2              4.5.2              Symfony SonataUserBundle

Symfony packages

$ composer show --latest 'symfony/*'
Restricting packages listed in "symfony/symfony" to "~4.4.0"
symfony/acl-bundle                 v1.0.1  v2.0.0  Symfony AclBundle
symfony/apache-pack                v1.0.1  v1.0.1  A pack for Apache support in Symfony
symfony/asset                      v4.4.5  v4.4.5  Symfony Asset Component
symfony/browser-kit                v4.4.5  v4.4.5  Symfony BrowserKit Component
symfony/cache                      v4.4.5  v4.4.5  Symfony Cache component with PSR-6, PSR-16, and tags
symfony/cache-contracts            v2.0.1  v2.0.1  Generic abstractions related to caching
symfony/config                     v4.4.5  v4.4.5  Symfony Config Component
symfony/console                    v4.4.5  v4.4.5  Symfony Console Component
symfony/css-selector               v4.4.5  v4.4.5  Symfony CssSelector Component
symfony/debug                      v4.4.5  v4.4.5  Symfony Debug Component
symfony/debug-bundle               v4.4.5  v4.4.5  Symfony DebugBundle
symfony/dependency-injection       v4.4.5  v4.4.5  Symfony DependencyInjection Component
symfony/doctrine-bridge            v4.4.5  v4.4.5  Symfony Doctrine Bridge
symfony/dom-crawler                v4.4.5  v4.4.5  Symfony DomCrawler Component
symfony/dotenv                     v4.4.5  v4.4.5  Registers environment variables from a .env file
symfony/error-handler              v4.4.5  v4.4.5  Symfony ErrorHandler Component
symfony/event-dispatcher           v4.4.5  v4.4.5  Symfony EventDispatcher Component
symfony/event-dispatcher-contracts v1.1.7  v2.0.1  Generic abstractions related to dispatching event
symfony/expression-language        v4.4.5  v4.4.5  Symfony ExpressionLanguage Component
symfony/filesystem                 v4.4.5  v4.4.5  Symfony Filesystem Component
symfony/finder                     v4.4.5  v4.4.5  Symfony Finder Component
symfony/flex                       v1.6.2  v1.6.2  Composer plugin for Symfony
symfony/form                       v4.4.5  v4.4.5  Symfony Form Component
symfony/framework-bundle           v4.4.5  v4.4.5  Symfony FrameworkBundle
symfony/http-foundation            v4.4.5  v4.4.5  Symfony HttpFoundation Component
symfony/http-kernel                v4.4.5  v4.4.5  Symfony HttpKernel Component
symfony/inflector                  v4.4.5  v4.4.5  Symfony Inflector Component
symfony/intl                       v4.4.5  v4.4.5  A PHP replacement layer for the C intl extension that includes additional data from the ICU library.
symfony/maker-bundle               v1.14.4 v1.14.4 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code.
symfony/mime                       v4.4.5  v4.4.5  A library to manipulate MIME messages
symfony/monolog-bridge             v4.4.5  v4.4.5  Symfony Monolog Bridge
symfony/monolog-bundle             v3.5.0  v3.5.0  Symfony MonologBundle
symfony/options-resolver           v4.4.5  v4.4.5  Symfony OptionsResolver Component
symfony/orm-pack                   v1.0.8  v1.0.8  A pack for the Doctrine ORM
symfony/phpunit-bridge             v4.4.5  v5.0.5  Symfony PHPUnit Bridge
symfony/polyfill-intl-icu          v1.14.0 v1.14.0 Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn          v1.14.0 v1.14.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-mbstring          v1.14.0 v1.14.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php72             v1.14.0 v1.14.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73             v1.14.0 v1.14.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/process                    v4.4.5  v4.4.5  Symfony Process Component
symfony/profiler-pack              v1.0.4  v1.0.4  A pack for the Symfony web profiler
symfony/property-access            v4.4.5  v4.4.5  Symfony PropertyAccess Component
symfony/proxy-manager-bridge       v4.4.5  v4.4.5  Symfony ProxyManager Bridge
symfony/routing                    v4.4.5  v4.4.5  Symfony Routing Component
symfony/security-acl               v3.0.4  v3.0.4  Symfony Security Component - ACL (Access Control List)
symfony/security-bundle            v4.4.5  v4.4.5  Symfony SecurityBundle
symfony/security-core              v4.4.5  v4.4.5  Symfony Security Component - Core Library
symfony/security-csrf              v4.4.5  v4.4.5  Symfony Security Component - CSRF Library
symfony/security-guard             v4.4.5  v4.4.5  Symfony Security Component - Guard
symfony/security-http              v4.4.5  v4.4.5  Symfony Security Component - HTTP Integration
symfony/service-contracts          v2.0.1  v2.0.1  Generic abstractions related to writing services
symfony/stopwatch                  v4.4.5  v4.4.5  Symfony Stopwatch Component
symfony/swiftmailer-bundle         v3.4.0  v3.4.0  Symfony SwiftmailerBundle
symfony/templating                 v4.4.5  v4.4.5  Symfony Templating Component
symfony/translation                v4.4.5  v4.4.5  Symfony Translation Component
symfony/translation-contracts      v2.0.1  v2.0.1  Generic abstractions related to translation
symfony/twig-bridge                v4.4.5  v4.4.5  Symfony Twig Bridge
symfony/twig-bundle                v4.4.5  v4.4.5  Symfony TwigBundle
symfony/validator                  v4.4.5  v4.4.5  Symfony Validator Component
symfony/var-dumper                 v4.4.5  v4.4.5  Symfony mechanism for exploring and dumping PHP variables
symfony/var-exporter               v4.4.5  v4.4.5  A blend of var_export() + serialize() to turn any serializable data structure to plain PHP code
symfony/web-profiler-bundle        v4.4.5  v4.4.5  Symfony WebProfilerBundle
symfony/web-server-bundle          v4.4.5  v4.4.5  Symfony WebServerBundle
symfony/webpack-encore-bundle      v1.7.3  v1.7.3  Integration with your Symfony app & Webpack Encore!
symfony/yaml                       v4.4.5  v4.4.5  Symfony Yaml Component

Twig packages

$ composer show --latest 'twig/*'
twig/cache-extension dev-master d715cd7 dev-master d715cd7 Cache fragments of templates directly within Twig.
twig/extensions      v1.5.4             v1.5.4             Common additional features for Twig that do not directly belong in core
twig/extra-bundle    v3.0.3             v3.0.3             A Symfony bundle for extra Twig extensions
twig/intl-extra      v3.0.3             v3.0.3             A Twig extension for Intl
twig/twig            v2.12.5            v3.0.3             Twig, the flexible, fast, and secure template language for PHP

PHP version

$ php -v
PHP 7.4.3 (cli) (built: Feb 20 2020 14:15:45) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
    with Xdebug v2.9.2, Copyright (c) 2002-2020, by Derick Rethans

Subject

The global language switcher, as documented here, uses a non existing twig filter language which is not to be found in any current official twig extensions. Twig included a similiar language_name since 2.12, which seems to do the job. Overriding the standard_layout.html.twig template and changing the filter fixes this.

Steps to reproduce

  1. Setup the global language switcher as per documentation.
  2. Try to access the dashboard or any other admin page.

Expected results

Admin page shows as per request.

Actual results

Twig\Error\SyntaxError:
Unknown "language" filter. Did you mean "language_name"?

  at vendor/sonata-project/translation-bundle/src/Resources/views/standard_layout.html.twig:35
  at Twig\ExpressionParser->getFilterNodeClass()
     (vendor/twig/twig/src/ExpressionParser.php:554)
  at Twig\ExpressionParser->parseFilterExpressionRaw()
     (vendor/twig/twig/src/ExpressionParser.php:539)
  at Twig\ExpressionParser->parseFilterExpression()
     (vendor/twig/twig/src/ExpressionParser.php:397)
  at Twig\ExpressionParser->parsePostfixExpression()
     (vendor/twig/twig/src/ExpressionParser.php:289)
  at Twig\ExpressionParser->parsePrimaryExpression()
     (vendor/twig/twig/src/ExpressionParser.php:175)
  at Twig\ExpressionParser->getPrimary()
     (vendor/twig/twig/src/ExpressionParser.php:70)
  at Twig\ExpressionParser->parseExpression()
     (vendor/twig/twig/src/Parser.php:142)
  at Twig\Parser->subparse()
     (vendor/twig/twig/src/TokenParser/ForTokenParser.php:52)
  at Twig\TokenParser\ForTokenParser->parse()
     (vendor/twig/twig/src/Parser.php:185)
  at Twig\Parser->subparse()
     (vendor/twig/twig/src/TokenParser/BlockTokenParser.php:45)
  at Twig\TokenParser\BlockTokenParser->parse()
     (vendor/twig/twig/src/Parser.php:185)
  at Twig\Parser->subparse()
     (vendor/twig/twig/src/TokenParser/BlockTokenParser.php:45)
  at Twig\TokenParser\BlockTokenParser->parse()
     (vendor/twig/twig/src/Parser.php:185)
  at Twig\Parser->subparse()
     (vendor/twig/twig/src/Parser.php:98)
  at Twig\Parser->parse()
     (vendor/twig/twig/src/Environment.php:563)
  at Twig\Environment->parse()
     (vendor/twig/twig/src/Environment.php:595)
  at Twig\Environment->compileSource()
     (vendor/twig/twig/src/Environment.php:408)
  at Twig\Environment->loadClass()
     (vendor/twig/twig/src/Environment.php:381)
  at Twig\Environment->loadTemplate()
     (vendor/twig/twig/src/Template.php:335)
  at Twig\Template->loadTemplate()
     (var/cache/dev/twig/0c/0cd9b0182393a72c8eada239ab46e712cd33bda5b44ee06321a8577d15bc373c.php:54)
  at __TwigTemplate_53b1d0bf87a88ceb7e561eeba6551d06f33cc8818403513ec5e103599a6d9d78->doGetParent()
     (vendor/twig/twig/src/Template.php:99)
  at Twig\Template->getParent()
     (var/cache/dev/twig/0c/0cd9b0182393a72c8eada239ab46e712cd33bda5b44ee06321a8577d15bc373c.php:66)
  at __TwigTemplate_53b1d0bf87a88ceb7e561eeba6551d06f33cc8818403513ec5e103599a6d9d78->doDisplay()
     (vendor/twig/twig/src/Template.php:407)
  at Twig\Template->displayWithErrorHandling()
     (vendor/twig/twig/src/Template.php:380)
  at Twig\Template->display()
     (vendor/twig/twig/src/Template.php:392)
  at Twig\Template->render()
     (vendor/symfony/twig-bridge/TwigEngine.php:54)
  at Symfony\Bridge\Twig\TwigEngine->render()
     (vendor/symfony/framework-bundle/Controller/ControllerTrait.php:233)
  at Sonata\AdminBundle\Controller\CRUDController->originalRender()
     (vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php:119)
  at Sonata\AdminBundle\Controller\CRUDController->renderWithExtraParams()
     (vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php:95)
  at Sonata\AdminBundle\Controller\CRUDController->render()
     (src/MyBundle/Controller/Admin/BaseAdminController.php:108)
  at MyBundle\Controller\Admin\BaseAdminController->listAction()
     (vendor/symfony/http-kernel/HttpKernel.php:146)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor/symfony/http-kernel/HttpKernel.php:68)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor/symfony/http-kernel/Kernel.php:201)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (public/index_dev.php:37)
franmomu commented 4 years ago

Thank you @BigBadBassMan for reporting this! can you please make a PR using language_name and bumping twig to 2.12?

BigBadBassMan commented 4 years ago

Thank you @BigBadBassMan for reporting this! can you please make a PR using language_name and bumping twig to 2.12?

done as #328 , for now targeting master, as the twig version bump may be bc-breaking