search

sonata-project / SonataUserBundle

Symfony SonataUserBundle
https://docs.sonata-project.org/projects/SonataUserBundle
MIT License
341 stars 487 forks source link

Enable autowire and autoconfigure for sonata.user.admin.user service #1662

Closed dmikhinev closed 9 months ago

dmikhinev commented 1 year ago

Subject

Enable autowire and autoconfigure for sonata.user.admin.user service

I am targeting this branch, because changes are related to current version.

Changelog

### Added
- Enabled autowire and autoconfigure for sonata.user.admin.user service
jordisala1991 commented 11 months ago

Why should we enable autowire and autoconfiguration for this service if it already injects all dependencies and tags? I think this change is not needed.

dmikhinev commented 11 months ago

@jordisala1991 what if i need to inject some additional services? For example file uploader service to upload user profile photo?

VincentLanglet commented 9 months ago

@jordisala1991 what if i need to inject some additional services? For example file uploader service to upload user profile photo?

Then it's your service which will need autoconfigure, not the one defined by sonata no ?

Anyway, since none of our service use those tags, I think we should keep consistency.