search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
332 stars 29 forks source link

fix wrong predis cluster namespace in predis cache adapter #117

Closed nanofelis closed 6 years ago

nanofelis commented 6 years ago

I am targeting this branch, because this is a patch.

Changelog

### Fixed
- Fixed the `PredisCluster` namespace in `PRedisCacheAdapter`

Subject

Predis caches could not be flushed on clusters because the PRedisCluser namespace was wrong.

greg0ire commented 6 years ago

Here is the commit responsible for that change: https://github.com/nrk/predis/commit/abd284c9725586b3adf8bde08bbb8e76598ce74c

It is present since v1.0.0 and we conflict with versions lower than that: https://github.com/sonata-project/cache/blob/b26ddf6fbdd7d45073f42f4403e68ba8ab33a537/composer.json#L28-L31

This means you can safely drop the conditional

mremi commented 6 years ago

@greg0ire good to merge?

greg0ire commented 6 years ago

@mremi yes

greg0ire commented 6 years ago

Thanks @nanofelis !