PRedisCache fixes - Githubissues

sonata-project / cache

[Deprecated] Cache library

https://github.com/sonata-project/cache

MIT License

332 stars 29 forks source link

PRedisCache fixes #2

Closed ryzy closed 10 years ago

ryzy commented 10 years ago

Hi Thomas

These fix:

bug which we discussed on IRC with invalid return from ::flushAll()
fixes invalid parameter assignment in constructor (so connection parameters were not passed to Redis client)
some solution for clustering mode, which is not needed when only one connection info is passed (but I'm not sure, maybe it should be solved somewhere at earlier stage, before it's passed here?)

rande commented 10 years ago

You are not working with a stable version of PRedis branch, the code has been tested against the 0.8 branch. And you are using the master branch (next 1.0)

rande commented 10 years ago

I just update cache bundle dependencies

ryzy commented 10 years ago

Good, thanks - at least the issue with ::flushAll() is solved.

I lost a bit interest in that Adapter once I discovered there’s no tags support - I was sure it’s easy to achieve it with Redis.

Is there any particular reason why you didn’t finish implementing it? Just lack of time or you hit some problems?

Any suggestion if I’d like to finish it?

On 27 Feb 2014, at 09:01 pm, Thomas notifications@github.com wrote:

Closed #2.

— Reply to this email directly or view it on GitHub.

rande commented 10 years ago

It is almost done: https://github.com/sonata-project/cache/blob/master/lib/Adapter/Cache/PRedisCache.php#L85-L99

I will add a dedicated method in the interface to properly remove a cache entry by a key value.