sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
331 stars 29 forks source link

Restrict test classes to the development autoload #45

Closed greg0ire closed 8 years ago

greg0ire commented 8 years ago

I am targetting this branch, because there is a BC-break : people might extend our test classes, who knows?

Changelog

### Removed
- Test classes autoload is no longer available when not in development

Subject

This PR restricts the autoload to test classes.

soullivaneuh commented 8 years ago

Would be great to do a grep of Sonata\Cache\Tests usage from all sonata projects and put the result here as a remember.

greg0ire commented 8 years ago

Would be great to do a grep of Sonata\Cache\Tests usage from all sonata projects and put the result here as a remember.

I could not find any results.

core23 commented 8 years ago

Refs https://github.com/sonata-project/dev-kit/issues/179

core23 commented 8 years ago

We should rename the test directory to Tests, because the Test directory should only contain all abstract test cases for other developers.

soullivaneuh commented 8 years ago

We should rename the test directory to Tests, because the Test directory should only contain all abstract test cases for other developers.

You're talking about bundle repositories using the "old" directory structure.

Here, public test cases would be under src/Test and test classes under test.

Those folders are not part of the namespace thanks to PSR-4.

core23 commented 8 years ago

Here, public test cases would be under src/Test and test classes under test.

Sorry, you're absolutely right. Didn't think about that.

SonataCI commented 8 years ago

Could you please rebase your PR and fix merge conflicts?

core23 commented 8 years ago

Should we merge this in the stable branch @Soullivaneuh ?

Same as https://github.com/sonata-project/ecommerce/pull/384

soullivaneuh commented 8 years ago

If no test internal dependencies, yes.

core23 commented 8 years ago

Please create a new PR for the stable branch @greg0ire

greg0ire commented 8 years ago

I'm on holiday for 10 days, I'll do it after that, bit feel free to do it if you want to though.