Closed greg0ire closed 8 years ago
Would be great to do a grep of Sonata\Cache\Tests
usage from all sonata projects and put the result here as a remember.
Would be great to do a grep of Sonata\Cache\Tests usage from all sonata projects and put the result here as a remember.
I could not find any results.
We should rename the test
directory to Tests
, because the Test
directory should only contain all abstract test cases for other developers.
We should rename the
test
directory toTests
, because theTest
directory should only contain all abstract test cases for other developers.
You're talking about bundle repositories using the "old" directory structure.
Here, public test cases would be under src/Test
and test classes under test
.
Those folders are not part of the namespace thanks to PSR-4.
Here, public test cases would be under
src/Test
and test classes undertest
.
Sorry, you're absolutely right. Didn't think about that.
Could you please rebase your PR and fix merge conflicts?
Should we merge this in the stable branch @Soullivaneuh ?
Same as https://github.com/sonata-project/ecommerce/pull/384
If no test internal dependencies, yes.
Please create a new PR for the stable branch @greg0ire
I'm on holiday for 10 days, I'll do it after that, bit feel free to do it if you want to though.
I am targetting this branch, because there is a BC-break : people might extend our test classes, who knows?
Changelog
Subject
This PR restricts the autoload to test classes.