search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
331 stars 29 forks source link

Make it PSR-6 compliant #50

Closed soullivaneuh closed 2 years ago

soullivaneuh commented 8 years ago

Ref: http://www.php-fig.org/psr/psr-6/

Wait #49 before working on it.

greg0ire commented 7 years ago
  1. Implement PSR-6
  2. Make all dependents depend on PSR-6 instead of directly sonata-project/cache
  3. Abandon sonata-project/cache? Unless it has features that are unique to it?
core23 commented 7 years ago

Never been that deep into this component, but AFAIK symfony has a new cache component which would replace this repo. So we can abondon sonata cache.

greg0ire commented 7 years ago

Sonata libs depending on cache : block bundle, cache bundle, page bundle. Maybe we should also drop the cache bundle?

greg0ire commented 7 years ago

Not sure why block depends on it though : https://github.com/sonata-project/SonataBlockBundle/search?p=1&q=Cache&utf8=%E2%9C%93

greg0ire commented 7 years ago

Found the dependency : https://github.com/sonata-project/SonataBlockBundle/blob/3.x/DependencyInjection/SonataBlockExtension.php#L154 It's not very explicit, and is a dependency on the bundle more than on the library IMO

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

core23 commented 4 years ago

Making it PSR-6 compliant will help to deprecate this bundle #49 with a smooth upgrade path.

dmaicher commented 2 years ago

Going to have a look at this

dmaicher commented 2 years ago

We can close this one, right? I don't think there is a point in implementing this.

jordisala1991 commented 2 years ago

Yep, no point on using sonata cache since there is the Symfony one.

VincentLanglet commented 2 years ago

I thought it was to help the migration (for instance for the page bundle)

dmaicher commented 2 years ago

In case we see it would help the migration on the PageBundle we can maybe consider re-opening it. But not sure about it.