search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
331 stars 29 forks source link

Allow predis 1 #60

Closed greg0ire closed 7 years ago

greg0ire commented 7 years ago

I am targetting this branch, because this is BC.

The change is in the require-dev section, so pedantic.

greg0ire commented 7 years ago

@sonata-project/contributors please review

greg0ire commented 7 years ago

ping @core23

core23 commented 7 years ago

I don't use predis, so I can't review it :/

greg0ire commented 7 years ago

@core23 do you think I'm using predis ? @OskarStark do you?

core23 commented 7 years ago

How can you check if this will work? Allowing a new major won't work in all cases.

greg0ire commented 7 years ago

The test suite is fine with it, and that's all that should matter. People that find something broken can either use the older 0.* version, or provide a patch.

greg0ire commented 7 years ago

Plus, it's a require-dev dependency, so this should really be a no-brainer.

greg0ire commented 7 years ago

ping @core23