search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
331 stars 29 forks source link

Drop old versions of dependencies #64

Closed greg0ire closed 7 years ago

greg0ire commented 7 years ago

Only test dependencies were dropped, so this is pedantic.

core23 commented 7 years ago

We should also add conflicts version information.

greg0ire commented 7 years ago

What do you mean by that?

core23 commented 7 years ago

We don't use the conflict section to check the optional dependencies (defined under require-dev) are compatible.

greg0ire commented 7 years ago

Not sure that would be a great idea. If dependencies are optional and one of them is installed, how are we sure it's installed in order to be used with sonata cache?

greg0ire commented 7 years ago

ping @core23

greg0ire commented 7 years ago

ping @core23 @jordisala1991, WDYT?

jordisala1991 commented 7 years ago

Even if you dont add to conflicts, restriction will made you not be able to install older versions right? Not sure if its useful to add conflict section in this case.

core23 commented 7 years ago

The problem is, that we run our tests with higher versions of optional dependencies. If a someone uses a lower version of a dependency, there could be some problems with it.

jordisala1991 commented 7 years ago

Completely right, forgot about that case.

So when you declare dev-dependencies it doesn't block anyone using this bundle from installing a lower dependency, but when you put that on conflicts, you ensure that a higher dep gets installed. Is that right?

If this is the case, then 👍 to add conflicts.

Edited: only for the suggested packages or for everything?

greg0ire commented 7 years ago

@core23 please review again

greg0ire commented 7 years ago

@sonata-project/contributors please merge?

jordisala1991 commented 7 years ago

Squash or merge commit?

greg0ire commented 7 years ago

Regular merge please :)

jordisala1991 commented 7 years ago

Thanks @greg0ire :)