search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
332 stars 29 forks source link

Add void typehint back #87

Closed jlamur closed 6 years ago

jlamur commented 6 years ago

I am targeting this branch, because this is a BC break.

Changelog

### Changed
- Add void return typehints.

Subject

Since we dropped PHP 7.0 support on master, we can now add void return typehints back!

OskarStark commented 6 years ago

StyleCI is stuck. Can you help @Soullivaneuh ?

soullivaneuh commented 6 years ago

I am targeting this branch, because this is BC.

Did you mean BC break? Otherwise, the label and target branch are wrong.

jlamur commented 6 years ago

I am targeting this branch, because this is BC.

Did you mean BC break? Otherwise, the label and target branch are wrong.

I'm gonna pretend it meant "because this is Breaking Compatibility". Joke appart, of course this is not backward compatible. I updated the PR message.

greg0ire commented 6 years ago

Thanks @jlamur !

jordisala1991 commented 6 years ago

Doesn’t this change require an upgrade note?

greg0ire commented 6 years ago

IIRC there is already an upgrade note about signatures