search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
332 stars 29 forks source link

Added logger and php as a required deps #89

Closed core23 closed 6 years ago

core23 commented 6 years ago

I am targeting this branch, because this is BC.

Changelog

### Added
- Added php as a required dependency
- Added PSR logger as a required dependency

Subject

The PHP dependency was missing in the composer definition, also it is obviously a PHP programm 🤣 . The PSR logger is used inside the SimpleCacheInvalidation class.

core23 commented 6 years ago

@Soullivaneuh Can you have a look at StyleCI. Looks like it is disabled for this repo

soullivaneuh commented 6 years ago

@core23 Could you please explain a little bit why this is required on the PR and commit bodies?

soullivaneuh commented 6 years ago

The PSR cache

The PSR cache? You did require the log, not the cache. Mistyping?

core23 commented 6 years ago

Mistyping?

Yes. It's fixed now

greg0ire commented 6 years ago

Thanks @core23 !