search

sonata-project / cache

[Deprecated] Cache library
https://github.com/sonata-project/cache
MIT License
331 stars 29 forks source link

ISP violations #96

Closed greg0ire closed 3 years ago

greg0ire commented 7 years ago

Looking at the implementations of cache adapter show code smells revealing several ISP violations:

These methods should be extracted to separate interfaces, and implementing them should be optional.

Likewise, the isContextual method should be removed and replaced with a marker interface. https://github.com/sonata-project/SonataCacheBundle/blob/2.x/src/Adapter/SymfonyCache.php#L229-L232

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

VincentLanglet commented 3 years ago

Closing in favor of https://github.com/sonata-project/cache/issues/49