Closed OskarStark closed 4 years ago
- Add
bundle
andsymfony-bundle
to alle which ends with-bundle
bundle
seems enough to me.
But a symfony
keyword can be added too.
Note: sonata-exporter
contains a bundle part too
* Add `sonata` and `sonata-project` to all of our bundles
sonata-project
sound's confusing. I would expect a project that is based on sonata.
bundle
seems enough to me.
AFAIK symfony recommends symfony
, bundle
and symfony-bundle
for a symfony bundle.
After some discuss here: https://github.com/sonata-project/SonataAdminBundle/pull/6395#pullrequestreview-492012838
I think
php
should not be added. Everything is php
related when it can be downloaded with composer
. php
should only be use for something like a parser or a linter.symfony
and bundle
should definitely be used, since it's the most used keywords. I'm not convinced by symfony-bundle
which does seems to be a duplicate (and is not used a lot).sonata
should be used. sonata-project
seems redundant to me and less clear.Note: sonata-exporter contains a bundle part too
in this case we kann add it as a keyword to composer.json
Symfony uses php
and bundle
+ symfony-bundle
, so I am for adding symfony-bundle
, bundle
and php
This is the current result: https://gist.github.com/OskarStark/c93a0f273e714043f84164a38f180c01
Symfony uses
php
andbundle
+symfony-bundle
, so I am for addingsymfony-bundle
,bundle
andphp
It makes sense to add php
on github. Not on packagist.
Maybe we should modify dev-kit to automatically add php
? @OskarStark
Edit: I just saw your PR. Seems ok.
... based on
keywords
incomposer.json
.@VincentLanglet did the main work and I extracted a separate command which is currently inactive but generates the following output: https://gist.github.com/OskarStark/330839576097bb82219b7eceebbc3c7e
I would propose to use the keywords + some additional logic like:
php
to all of our bundlesbundle
andsymfony-bundle
to alle which ends with-bundle
sonata
andsonata-project
to all of our bundlesWe could also add the used services from the configuration as topics...