sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

Set repository topics via GithubApi... #1026

Closed OskarStark closed 4 years ago

OskarStark commented 4 years ago

... based on keywords in composer.json.

@VincentLanglet did the main work and I extracted a separate command which is currently inactive but generates the following output: https://gist.github.com/OskarStark/330839576097bb82219b7eceebbc3c7e

I would propose to use the keywords + some additional logic like:

We could also add the used services from the configuration as topics...

VincentLanglet commented 4 years ago
  • Add bundle and symfony-bundle to alle which ends with -bundle

bundle seems enough to me.

But a symfony keyword can be added too.

greg0ire commented 4 years ago

Note: sonata-exporter contains a bundle part too

core23 commented 4 years ago
* Add `sonata` and `sonata-project` to all of our bundles

sonata-project sound's confusing. I would expect a project that is based on sonata.

bundle seems enough to me.

AFAIK symfony recommends symfony, bundleand symfony-bundle for a symfony bundle.

VincentLanglet commented 4 years ago

After some discuss here: https://github.com/sonata-project/SonataAdminBundle/pull/6395#pullrequestreview-492012838

I think

OskarStark commented 4 years ago

Note: sonata-exporter contains a bundle part too

in this case we kann add it as a keyword to composer.json

OskarStark commented 4 years ago

Bildschirmfoto 2020-09-20 um 10 29 49

Symfony uses php and bundle + symfony-bundle, so I am for adding symfony-bundle, bundle and php

OskarStark commented 4 years ago

This is the current result: https://gist.github.com/OskarStark/c93a0f273e714043f84164a38f180c01

VincentLanglet commented 4 years ago

Symfony uses php and bundle + symfony-bundle, so I am for adding symfony-bundle, bundle and php

It makes sense to add php on github. Not on packagist. Maybe we should modify dev-kit to automatically add php ? @OskarStark

Edit: I just saw your PR. Seems ok.