sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

Symfony 6 Support #1675

Closed jordisala1991 closed 2 years ago

jordisala1991 commented 3 years ago

Active Bundles

Bundles that are used as dependencies

Bundles that do not support SF 5

Bundles with only Symfony dependencies on require-dev section

Final cleanup

The final step is cleanup composer.json and make sure all builds pass without requiring unstable dependencies

wbloszyk commented 3 years ago

Can you add Support for Symfony 5 section too?

jordisala1991 commented 3 years ago

I think there was an issue about sf 5.

jordisala1991 commented 3 years ago

@franmomu do you have time for help with DoctrineMongoDBAdminBundle?

jordisala1991 commented 3 years ago

SonataSeoBundle is ready too, @Kocal if you want to help with it

Kocal commented 3 years ago

Gonna give it a try this evening!

jordisala1991 commented 3 years ago

We are stuck because of the panther 🐈‍⬛ ...

Persistence bundles require it: https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/1562 It does not have support: https://github.com/symfony/panther/pull/509 It cant be easily added because it requires changes on the main Symfony or a new major version: https://github.com/symfony/symfony/issues/43021#issuecomment-955764741

Options:

  1. We do nothing and wait (we will not be day 1 compatible with Symfony 6, which would have been a huge success, and a selling point)
  2. We try to remove symfony/panther from 6.0 build until it gets fixed (not sure if it can be done)
  3. We get rid of Symfony Panther (not a good idea IMO, it is useful to test with JS)

What should we do? @sonata-project/contributors

jordisala1991 commented 2 years ago

The final step is cleanup composer.json and make sure all builds pass without requiring unstable dependencies. I have started with exporter and form-extensions, any help welcome @sonata-project/contributors

jordisala1991 commented 2 years ago

Symfony Security Acl is blocking the update to Symfony 6 , we might take a look and help them with that, otherwise our users cant update. https://github.com/symfony/security-acl/issues/99

VincentLanglet commented 2 years ago

Symfony Security Acl is blocking the update to Symfony 6 , we might take a look and help them with that, otherwise our users cant update. symfony/security-acl#99

Will be solved by https://github.com/symfony/security-acl/pull/100 :)

jordisala1991 commented 2 years ago

We are still blocked by the symfony acl :(

jordisala1991 commented 2 years ago

We are unblocked, tomorrow will try to check and fix SonataAdminBundle build.

We need to check all builds and remove the usage of unstable dependencies.

jordisala1991 commented 2 years ago

So all bundles are cleaned up, we just need a dev-kit PR.