search

sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

Lint twig templates via github actions as part of CI? #1829

Closed dmaicher closed 2 years ago

dmaicher commented 2 years ago

See https://github.com/sonata-project/SonataAdminBundle/pull/7669#issuecomment-1000217113

This could prevent such issues

VincentLanglet commented 2 years ago

@jordisala1991 You already said to me that most of our recent bug are twig related, this could be a great way to avoid it.

jordisala1991 commented 2 years ago

It would be nice, yes. IMO we should also have some functional tests that covers some of the basic features, that helps a lot too.

jordisala1991 commented 2 years ago

If we standarize how we create the test kernel across all bundles we can move some things to dev kit, and it would be nice, because that allows to execute console commands like lint twig or lint container (maybe there are others too)