Closed jordisala1991 closed 3 years ago
There are 2 bundles that were already started:
ClassificationBundle have an open PR from @franmomu . Since it is open from february I opened a new one. Do you mind if I continue you work? I would like to pick the documentation part of the PR.
NotificationBundle have a PR merged already. IMO it could be considered a BC break because you might not have DoctrineExtensions enabled, we should throw a deprecation and use EasyExtendsCollector, I can create a new PR and add the compatibility layer necessary. WDYT @sonata-project/contributors .
From now , all PRs are created and the changes on the code are applied, but I marked all draft because it is missing the docs change.
@phansys @core23 can you check any of the PR with and without this fix? https://github.com/sonata-project/sonata-doctrine-extensions/pull/184
All the bundles got the first iteration of the PR ready. There is still the problem with this PR, sonata-project/sonata-doctrine-extensions#184
There are 2 bundles that suffer directly from this problem in their PRs, because have functional tests: https://github.com/sonata-project/SonataPageBundle/pull/1162 and https://github.com/sonata-project/SonataMediaBundle/pull/1753
ping @core23 @phansys
Step 1 ready and released. Step 2 all PR ready to review.
I think we can close this issue @jordisala1991.
Since the SonataEasyExtends-related code is marked as deprecated it will be removed for sure in 4.0
Agree
Same issue like SonataCoreBundle for SonataEasyExtends. The bundle is deprecated since Symfony flex provides and easier path to install our bundles. The usages are on every bundle that defines Entities because it has a Doctrine Compiler pass to create the linking for the entities (associations, etc..)
The same code is on the https://github.com/sonata-project/sonata-doctrine-extensions The SonataEasyExtends is used by: https://github.com/sonata-project/SonataEasyExtendsBundle/network/dependents?dependent_type=PACKAGE&package_id=UGFja2FnZS01NDMwMzc3MjY%3D
The process is: