sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

Drop SonataEasyExtends in Sonata bundles #750

Closed jordisala1991 closed 3 years ago

jordisala1991 commented 4 years ago

Same issue like SonataCoreBundle for SonataEasyExtends. The bundle is deprecated since Symfony flex provides and easier path to install our bundles. The usages are on every bundle that defines Entities because it has a Doctrine Compiler pass to create the linking for the entities (associations, etc..)

The same code is on the https://github.com/sonata-project/sonata-doctrine-extensions The SonataEasyExtends is used by: https://github.com/sonata-project/SonataEasyExtendsBundle/network/dependents?dependent_type=PACKAGE&package_id=UGFja2FnZS01NDMwMzc3MjY%3D

The process is:

jordisala1991 commented 4 years ago

There are 2 bundles that were already started:

jordisala1991 commented 4 years ago

From now , all PRs are created and the changes on the code are applied, but I marked all draft because it is missing the docs change.

jordisala1991 commented 4 years ago

@phansys @core23 can you check any of the PR with and without this fix? https://github.com/sonata-project/sonata-doctrine-extensions/pull/184

jordisala1991 commented 4 years ago

All the bundles got the first iteration of the PR ready. There is still the problem with this PR, sonata-project/sonata-doctrine-extensions#184

There are 2 bundles that suffer directly from this problem in their PRs, because have functional tests: https://github.com/sonata-project/SonataPageBundle/pull/1162 and https://github.com/sonata-project/SonataMediaBundle/pull/1753

ping @core23 @phansys

jordisala1991 commented 4 years ago

Step 1 ready and released. Step 2 all PR ready to review.

VincentLanglet commented 3 years ago

I think we can close this issue @jordisala1991.

Since the SonataEasyExtends-related code is marked as deprecated it will be removed for sure in 4.0

jordisala1991 commented 3 years ago

Agree