search

sonata-project / dev-kit

Development kit of the Sonata-Project
https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/
42 stars 42 forks source link

[RFC] Rename `versions` into `variants` #877

Closed OskarStark closed 4 years ago

OskarStark commented 4 years ago

in projects.yaml

admin-search-bundle:
  branches:
    master:
      php: ['7.2', '7.3', '7.4']
      versions:
        symfony: ['4.4']
        sonata_admin: ['3']
        ruflin_elastica: ['5', '6']
    1.x:
      php: ['7.2', '7.3', '7.4']
      versions:
        symfony: ['4.4']
        sonata_admin: ['3']
        ruflin_elastica: ['5', '6']

IMO this is more meaningful

greg0ire commented 4 years ago

Agree, that would be slightly more understandable.

OskarStark commented 4 years ago

Will provide a PR 👌🏻

OskarStark commented 4 years ago

I created a PR https://github.com/sonata-project/dev-kit/pull/878