Fix support for doctrine/doctrine-bundle v2

sonata-project / ecommerce

[Abandoned] E-Commerce solution provided by Sonata

https://sonata-project.org

MIT License

165 stars 139 forks source link

Fix support for doctrine/doctrine-bundle v2 #771

Closed wbloszyk closed 3 years ago

wbloszyk commented 3 years ago

Subject

I am targeting this branch, because this change respect BC.

Changelog

### Changed
- Change usage of `Symfony\Bridge\Doctrine\RegistryInterface` into `Doctrine\Persistence\ManagerRegistry` (BC)

wbloszyk commented 3 years ago

@VincentLanglet We can keep ^1 and it will be work for both. Anyway in sandbox (so all ower bundles) we can use ^2.

We should keep support for 1.x or we can drop support for it becouse we fully support 2.x? WDYT @sonata-project/contributors @greg0ire

greg0ire commented 3 years ago

I'm torn: if it means extra work to keep ^1 I wouldn't keep it, but you seem to say it wouldn't. If there are code cleanups we could do by dropping it, then I would drop it.

wbloszyk commented 3 years ago

It is RTM.

OskarStark commented 3 years ago

Thanks