search

sonatype-nexus-community / bach

Dependency vulnerability auditor for PHP
Apache License 2.0
14 stars 15 forks source link

Php 8.0.0 #21

Closed bhamail closed 3 years ago

bhamail commented 3 years ago

Trying to get things to build and work with PHP 8.0.0.

Help on this is welcome!

DarthHater commented 3 years ago

@bhamail , https://github.com/laravel/tinker is what is enabled by tinker-zero. bach is using laravel-zero to build the application, so you probably removed something that the actual framework relies on, lol.

bhamail commented 3 years ago

@DarthHater Yep, and tinker-zero has require: "php": "^7.2.5", so not sure how to get that to play nice with php 8.

DarthHater commented 3 years ago

Screen Shot 2021-02-16 at 9 16 33 AM

DAN SHOOTS DAN SCORES

jkowalleck commented 3 years ago

@bhamail

thanks for your work on php8 support.

Anyways, this merge might have caused a lot of trouble, since this project had missing/insufficient CI tests. I think i might have found all the issues and came up with fixes or test mechanics for it.

DarthHater commented 3 years ago

@jkowalleck that is awesome (that you sent us PR's, etc...)