Confirm / Define PHP Versions supported for running bach

sonatype-nexus-community / bach

Dependency vulnerability auditor for PHP

Apache License 2.0

14 stars 15 forks source link

Closed madpah closed 3 years ago

madpah commented 3 years ago

Currently our composer.json states we are compatible with PHP "^7.1.3 || ^8.0".

This is not true as part of bach utilise PHP language features/constructs that are only available in PHP 7.4+.

See also Issue #30 which makes reference to this discrepancy.

Unless a compelling reason is forthcoming, I'd propose we support PHP 7.4 + and PHP 8+.

Thoughts @bhamail / @hboutemy / @DarthHater

bhamail commented 3 years ago

FWIW, I have no objection to a minimum PHP version of 7.4.

madpah commented 3 years ago

I think it's a safer position to be in to support execution on supported PHP versions - at least for now.

I'll prep a PR.

madpah commented 3 years ago

PR Merged - closing.