search

sonatype-nexus-community / cargo-pants

Apache License 2.0
28 stars 9 forks source link

Windows does not have / display properly the fonts or characters. #53

Closed ctunited15 closed 3 years ago

ctunited15 commented 3 years ago

I ran the command cargo pants from a Git bash window on my Windows machine. It completed successfully, but the output display couldn't find the proper characters. cargo_pants_windows

amy-keibler commented 3 years ago

I could be misreading your screenshot, but it appears that you have cargo-pants version 0.1.26 installed. We've recently published version 0.3.1, so upgrading might help with this issue. We recently switched how we display tables and that might solve this problem.

If upgrading doesn't solve the issue, we're using term-table's rounded styling to display the table and we could add a command-line flag to switch that to simple, which is more likely to display correctly. I do not have a windows machine to test this, so I likely cannot reproduce or test the issue. My guess is that we're outputting text as UTF-8, but the terminal expects a different encoding. I found a stackoverflow page of things I'd try if I could reproduce the issue, so maybe that might point you in the right direction until we have time to address this on our end?

I am also interested in the lock_ api crate part of the line starting with "Vulnerability Title:". I can reproduce that issue, so I will make a separate ticket to address that.

Thank you for filing this issue so we can ensure a good experience for users on other platforms and configurations.

DarthHater commented 3 years ago

@amy-keibler , @ctunited15 was running 0.3.1 on a prior commit of cargo-pants just to see it report more vulns! He indeed was running the newest.

DarthHater commented 3 years ago

This also seems to be worse than just the table, the unicode characters we use for the inverse dependency graph are wonky as well.

WINDOWS.