search

sonatype-nexus-community / copy-modules-webpack-plugin

A Webpack plugin which copies module sources to a separate directory
Apache License 2.0
18 stars 7 forks source link

refact: refactor dep detection for webpack v5 BUT src/** missing #21

Closed deleonio closed 3 years ago

deleonio commented 3 years ago

It relates to the following issue:

deleonio commented 3 years ago

@sokra can you give us a few pointers.

deleonio commented 3 years ago

@rpokorny the tests not working in orginial master and forked branch too.

rpokorny commented 3 years ago

@rpokorny the tests not working in orginial master and forked branch too.

Hello. Could you clarify what you mean by this? I just ran the tests on master today and they are passing for me locally.

rpokorny commented 3 years ago

The devDependency on webpack sets the version that is tested against. This PR does not change that, so the tests are still running against webpack 4. I believe you'd want to run them against webpack 5?

rpokorny commented 3 years ago

I've created an alternative PR which I believe addresses this more thoroughly.

deleonio commented 3 years ago

Thank you, it works.