Webpack 5 Support - Githubissues

sonatype-nexus-community / copy-modules-webpack-plugin

A Webpack plugin which copies module sources to a separate directory

Apache License 2.0

18 stars 7 forks source link

Webpack 5 Support #22

Closed rpokorny closed 3 years ago

rpokorny commented 3 years ago

Add support for Webpack 5

This pull request makes the following changes:

Switches to the simpler compilation.fileDependencies property rather than module.fileDependencies which doesn't appear to exist in webpack 5.
Adds a dependency on webpack 5 in addition to the one for webpack 4
Tests in both versions
Doc update around the behavior of includePackageJsons in webpack 5

Note that webpack 5 includes the relevant package.json files in its fileDependencies list automatically, avoiding the need for us to calculate it ourselves (and removing the value of the includePackageJsons flag.

It relates to the following issue #s:

Fixes #20

rpokorny commented 3 years ago

@deleonio let me know if this works for you.

deleonio commented 3 years ago

I will check it soon

deleonio commented 3 years ago

It works!

There is a slight difference. Which shouldn't be relevant because it can be traced back to Webpack.

NO DIFF webpack@^4 + copy-modules-webpack-plugin@2.1.1 vs webpack@^4 + copy-modules-webpack-plugin@PR22 (#22)

TINY DIFF webpack@^4 + copy-modules-webpack-plugin@2.1.1 vs webpack@^5 + copy-modules-webpack-plugin@PR22 (#22)

rpokorny commented 3 years ago

These changes have been published as version 2.2.0 of this plugin.