search

sonatype-nexus-community / copy-modules-webpack-plugin

A Webpack plugin which copies module sources to a separate directory
Apache License 2.0
18 stars 7 forks source link

fix: some webpack plugins rename the files and that would be catched now #26

Closed deleonio closed 3 years ago

deleonio commented 3 years ago

We have identified a Webpack plugin for @angular that changes the filenames when compiling from TS to JS. In order to find the sources for the Nexus IQ, separate error handling is required.

This PR fixed https://github.com/sonatype-nexus-community/copy-modules-webpack-plugin/issues/25

rpokorny commented 3 years ago

I have an alternative fix which is simpler and IMO less dubious than searching for similarly-named files as this PR does. Please see https://github.com/sonatype-nexus-community/copy-modules-webpack-plugin/pull/27

304NotModified commented 3 years ago

as #27 is merged, this one could be closed?

deleonio commented 3 years ago

@304NotModified and @rpokorny

No, because all ts files does not copied correct.

I have update this repo to reproduce it - now it looks okay. https://github.com/sonatype-nexus-community/copy-modules-webpack-plugin/issues/25#issue-780160373

rpokorny commented 3 years ago

Closing as I cannot reproduce the underlying issue (#25)