search

sonatype-nexus-community / copy-modules-webpack-plugin

A Webpack plugin which copies module sources to a separate directory
Apache License 2.0
18 stars 7 forks source link

Webpack 4 support #3

Closed seminolas closed 6 years ago

seminolas commented 6 years ago

Make plugin compatible with webpack 4

This pull request makes the following changes:

rpokorny commented 6 years ago

When I run npm install on this branch, I'm getting a bunch of package-lock.json changes, even if I delete node_modules and clean my npm cache first.

rpokorny commented 6 years ago

I get test failures on this branch

seminolas commented 6 years ago

Sorry for that, obviously I made incorrect assumptions about how npm works. The test should pass now, and I re-ran npm install on top of the previous lock file - hopefully that should make it stable.

Also, this change renders the plugin incompatible with earlier versions of webpack - should that be mentioned in the readme?

rpokorny commented 6 years ago

Also, this change renders the plugin incompatible with earlier versions of webpack - should that be mentioned in the readme?

Yes, if we know it'll only work with Webpack 4 we should mention that in the readme.