sonatype-nexus-community / helm-nexus-push

A plugin for helm that will push a chart to a Nexus Hosted Repository
Apache License 2.0
43 stars 47 forks source link

Fix/bash env test #1

Open msutter opened 5 years ago

msutter commented 5 years ago

Using the plugin in some docker images produce an 'unbound variable' error by pushing charts to the nexus repository.

You can reproduce this issue by using the 'devth/helm' docker image.

This pull request makes the following changes:

sonatypecla[bot] commented 5 years ago

Thanks for the contribution! Before we can merge this, we need @msutter to sign the Sonatype Contributor License Agreement.

DarthHater commented 5 years ago

@dtshepherd wdyt about this one?

dtshepherd commented 5 years ago

Sorry @DarthHater, I've just been absolutely slammed at work lately. This PR looks good and I see an overlapping PR #2. I like this one more because it keeps the set -u, so maybe just add the rename of USERNAME to REPO_USERNAME, so the script doesn't create a conflict with Ubuntu?

dtshepherd commented 5 years ago

@msutter Did you want to make the change I suggested above so we can get this merged? (sorry for being slow to respond, slammed in my day job...)

marcoreni commented 5 years ago

@dtshepherd @DarthHater any updates on this? After the changes suggested in https://github.com/sonatype-nexus-community/helm-nexus-push/pull/1#issuecomment-454416478 it should be straightforward to merge, right?

dtshepherd commented 5 years ago

Yeah, should be. If I find some spare cycles this week, I can fork this change and apply my suggested fix.

anton-johansson commented 4 years ago

Any news here? I just upgraded my Nexus to get native Helm chart support, but I got stuck here. :)