search

sonatype-nexus-community / helm-nexus-push

A plugin for helm that will push a chart to a Nexus Hosted Repository
Apache License 2.0
43 stars 47 forks source link

fix a case on some shells that the declare results on a undeclared variable #16

Open jhonatanTeixeira opened 4 years ago

jhonatanTeixeira commented 4 years ago

leading to an assertion error

Just added equal signs to the declare, so it behave correctly, and the if -z assertion works as intended. However, i only tested on ubuntu 18 machine, wich is the OS that was trying to use this script.

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Before we can merge this, we need @jhonatanTeixeira to sign the Sonatype Contributor License Agreement.

tuxBurner commented 4 years ago

Could we please merge this ?

I wasted another hour to find the same solution :)

Guararapes commented 4 years ago

I have just signed the contributor licence