sonatype-nexus-community / helm-nexus-push

A plugin for helm that will push a chart to a Nexus Hosted Repository
Apache License 2.0
43 stars 47 forks source link

remove set -u and reserved variable USERNAME #2

Open maozza opened 5 years ago

maozza commented 5 years ago

fix unbound variable error, the script call USERNAME and PASSWORD before setting it. USERNAME is reserved in Ubuntu 18.04

This pull request makes the following changes:

(If there are changes to user behavior in general, please make sure to update the docs, as well)

It relates to the following issue #s:

sonatypecla[bot] commented 5 years ago

Thanks for the contribution! Unfortunately we can't verify if the committer(s), maoz maoz@leadspace.com, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

dtshepherd commented 5 years ago

@maozza See PR #1. We'll likely work on getting that one merged.