search

sonatype-nexus-community / iq-github-action

Sonatype Lifecycle GitHub Action
Apache License 2.0
9 stars 10 forks source link

Missing linting configuration #18

Open ModeSevenIndustrialSolutions opened 1 week ago

ModeSevenIndustrialSolutions commented 1 week ago

We're missing a .pre-commit-config.yaml file in this repository.

Obvious problems/errors are creeping into the action code as a result.

Also, it's probably worth adding the pre-commit.ci app to this repository, which will run the linting setup even if users don't install the pre-commit hook and check their code/patches.

ModeSevenIndustrialSolutions commented 1 week ago

Suggested linting setup is raised in a pull request here: https://github.com/sonatype-nexus-community/iq-github-action/pull/21 Feel free to review and suggest changes?

ModeSevenIndustrialSolutions commented 1 week ago

Here's the link to the pre-commit.ci "Github app" on the marketplace: https://github.com/marketplace/pre-commit-ci We probably should consider enabling this, or something along these lines, on repositories containing a linting setup/configuration.