Closed cshaley closed 9 months ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
cc @bhamail / @DarthHater please review / merge if appropriate
Hi @bhamail cc. @madpah @bollwyvl @maarre @gregegg
Could you consider reviewing and merging this PR please. A new release will enable all of us again with jake ! Thanks & Regards.
Thank you @bhamail - It looks like we need an approval to release & publish to pypi. https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1339/workflows/26dbe621-5002-4e92-b56f-8d56795f2767
Thank you @bhamail - It looks like we need an approval to release & publish to pypi. https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1339/workflows/26dbe621-5002-4e92-b56f-8d56795f2767
Doh! Yes indeed. Button mashed. Fingers crossed.
@bhamail As I understand, versioning of jake is automated. It looks like the build tried to publish 3.0.1 again, and it failed.
What's the right next step to get jake updated with the new dependency specification?
@cshaley I tried manually incrementing the version and doing a manual release. I don't see errors in the build, but I don't see the new release in pypi either. Please ping again if nothing shows up by tomorrow.
@bhamail - looks like no release published on PyPi - https://pypi.org/project/jake/#history or even on github https://github.com/sonatype-nexus-community/jake/releases - the semantic release step - shows no log - but on the prior step - i do see a warning on poetry-lock being out of date. That shouldn't have prevented the release..
@bhamail https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1342/workflows/fbc35697-a32c-4121-a5e4-7a9049b46ac6/jobs/3072 It looks like it's working, but not showing up in pypi!
I'm thinking the semantic-release publish
step is failing silently. It looks like it also failed (not silently) for all attempts to publish jake 3.0.1 - at least the ones in the publish history that I can see eg 1335 and 1340. So I'm not too sure how 3.0.1 got published to pypi unless it was before the visible history on circleci.
@bhamail thoughts on next steps? It looks like we could do semantic-release -v publish
or semantic-release -vv publish
to get it to output more information.
@bhamail thanks for taking the next step.
I think I diagnosed it. python-semantic-release has breaking changes in v8.
So two options:
semantic-release version
twine upload dist/*
semantic-release publish
From reading the python-semantic-release docs linked above, I think jake's current process automatically handles version updates (i.e. v7 of semantic-release updates jake's version in github as part of the publish command). So I think we need all three lines above. Note: this probably means adding twine to the pip install line too. I'll raise a PR with approach 2.
Hi @bhamail cc. @madpah @bollwyvl @maarre @gregegg
Could you consider reviewing and merging this PR please. A new release will enable all of us again with jake ! Thanks & Regards.
Thanks everyone!
This pull request makes the following changes:
(If there are changes to user behavior in general, please make sure to update the docs, as well)
It relates to the following issue #s: