search

sonatype-nexus-community / jake

Check your Python environments for vulnerable Open Source packages with OSS Index or Sonatype Nexus Lifecycle.
https://jake.readthedocs.io/
Apache License 2.0
111 stars 24 forks source link

try to get a test running #89

Closed bhamail closed 2 years ago

bhamail commented 2 years ago

Flailings about creating a simple test to appease coverage report.

I suspect a problem with this tox config: https://github.com/sonatype-nexus-community/jake/blob/main/tox.ini#L27

cc @bhamail / @DarthHater

madpah commented 2 years ago

There were never any tests (upstream libraries do the tests currently). Would need refactoring to enable testing. Will try to get back to where it was prior to this failure.

madpah commented 2 years ago

@bhamail - so, it was my bad.

I started the process of adding tests when working on #87, but concluded a notable (non-trivial) refactor would be required to enable testing - so removed tests, but not the empty file.

Forgive me :-)

Have raised #90.

bhamail commented 2 years ago

@bhamail - so, it was my bad.

I started the process of adding tests when working on #87, but concluded a notable (non-trivial) refactor would be required to enable testing - so removed tests, but not the empty file.

Forgive me :-)

Have raised #90.

Hi @madpah, Thanks for looking! Unfortunately, the current build failure in the internal Jenkins build is due to no test results being found - so deleting the test class just gets back to that same failure state.

I'm trying a different option now, that alters the testenv command in tox.ini. If I get that happy, it may suffice as a workaround until #90 happens.

bhamail commented 2 years ago

I think my latest changes have a working unit test and should calm the internal build. Please holler if you see anything horrific.

bhamail commented 2 years ago

No objections, so gonna merge.