Make OSSIndex TTL a config flag - Githubissues

sonatype-nexus-community / nancy

A tool to check for vulnerabilities in your Golang dependencies, powered by Sonatype OSS Index

Apache License 2.0

566 stars 75 forks source link

Make OSSIndex TTL a config flag #123

Open zendern opened 4 years ago

zendern commented 4 years ago

What are you trying to do? Allow for more configurability
What feature or behavior is this required for? Allow people to set how long the TTL for the cached values from ossindex is set for.

https://github.com/sonatype-nexus-community/nancy/blob/a76019e8e219793dc69cf517029fc554a9d2cf6d/ossindex/ossindex.go#L165

How could we solve this issue? (Not knowing is okay!) Make it configurable and use that value....probably want some logging around it as well.
Anything else? Possible downside if someone decided to set it to a lower value could get rate limited

cc @bhamail / @DarthHater

DarthHater commented 4 years ago

I doubt we want this as a command line flag, and more so a persistent config value. Any opinions there @zendern ?