sonatype-nexus-community / nancy

A tool to check for vulnerabilities in your Golang dependencies, powered by Sonatype OSS Index
Apache License 2.0
549 stars 76 forks source link

Docker tests ftw #195

Closed zendern closed 3 years ago

zendern commented 3 years ago

This pull request makes the following changes:

It relates to the following issue #s:

cc @bhamail / @DarthHater

bhamail commented 3 years ago

This is waaay cool! I was seeing some errors when calling docker build on macos.

Found this: https://discuss.circleci.com/t/circleci-build-local-machine-fails-when-using-setup-remote-docker/15487 and: https://stackoverflow.com/questions/45796661/docker-permission-denied-while-trying-to-connect-to-docker-daemon-with-local-ci I'm working on a diff that fixes things 'nuff to allow my local CI build to succeed - basically by running 'sudo docker' when local.

For reference, here's the command I'm using to run a local CI build:

circleci config process .circleci/config.yml > .circleci/local-config.yml && circleci local execute -c .circleci/local-config.yml --job 'build'
zendern commented 3 years ago

This is waaay cool! I was seeing some errors when calling docker build on macos.

Found this: https://discuss.circleci.com/t/circleci-build-local-machine-fails-when-using-setup-remote-docker/15487 and: https://stackoverflow.com/questions/45796661/docker-permission-denied-while-trying-to-connect-to-docker-daemon-with-local-ci I'm working on a diff that fixes things 'nuff to allow my local CI build to succeed - basically by running 'sudo docker' when local.

For reference, here's the command I'm using to run a local CI build:

circleci config process .circleci/config.yml > .circleci/local-config.yml && circleci local execute -c .circleci/local-config.yml --job 'build'

Alright finally got around to looking at this. But take a peek at this commit and try to run it again for me please. 2e4c7a0 Details of what is going on are in that commit.

bhamail commented 3 years ago

@zendern Oh, snaaaap! Nicely done. Works like a champ! Merging it right away!!!! Thanks fo much!