When a replace happened to a package that was internal to the project it
blew up this fixes that and validates that the versions should be pulled
from pre-internal project replace and still scanned.
As the comment says it'll still pull in the old version pre replace and send it along for scanning. Need to determine if that is the right thing to do or not.
Example
github.com/ory/kratos-client-go v0.5.4-alpha.1 => ./internal/httpclient
Will end up as
github.com/ory/kratos-client-go v0.5.4-alpha.1
Is that what we want or should we just drop it on the floor (maybe log something??) due to the re-write not having a version.
Also fair warning I didn't make that many changes to the test but I did split them from the one big test into their own individual ones so that they could be run individually while validating this change.
☝️ hopefully have this happen less 😄
When a replace happened to a package that was internal to the project it blew up this fixes that and validates that the versions should be pulled from pre-internal project replace and still scanned.
As the comment says it'll still pull in the old version pre replace and send it along for scanning. Need to determine if that is the right thing to do or not.
Example
github.com/ory/kratos-client-go v0.5.4-alpha.1 => ./internal/httpclient
Will end up as
github.com/ory/kratos-client-go v0.5.4-alpha.1
Is that what we want or should we just drop it on the floor (maybe log something??) due to the re-write not having a version.
Also fair warning I didn't make that many changes to the test but I did split them from the one big test into their own individual ones so that they could be run individually while validating this change.
It relates to the following issue #s:
cc @bhamail / @DarthHater / @aeneasr