sonatype-nexus-community / nancy

A tool to check for vulnerabilities in your Golang dependencies, powered by Sonatype OSS Index
Apache License 2.0
562 stars 74 forks source link

do not publish Dockerfile.alpine image #230

Closed bhamail closed 3 years ago

bhamail commented 3 years ago

Not sure why, but after making an unrelated change to goreleaser.yml (for Issue #229), the goreleaser call is failing (both locally and on CircleCI) when trying to create the second alpine docker image for publishing:

$ goreleaser  --snapshot --skip-publish --rm-dist
...
   • docker images    
      • building docker image     buildx=false image=sonatypecommunity/nancy:latest
   ⨯ release failed after 9.54s error=failed to link dockerfile: link build/Dockerfile.alpine dist/goreleaserdocker055539225/Dockerfile: no such file or directory

CircleCI failure

After banging my head on a wall trying to solve this build failure (with no success), I'm wondering if we should just stop publishing the failing docker image (from Dockerfile.alpine)?

Both the successful docker image (from Dockerfile.goreleaser) and the failing docker image (from Dockerfile.alpine) are alpine based images. The successful image is "from scratch", and is much smaller.

Any objection to changing the build to only publish the docker image built from Dockerfile.goreleaser?

WAIT, STOP, I think there is a different problem causing this - will likely delete this PR when things are clearer

cc @bhamail / @DarthHater

zendern commented 3 years ago

231 is the real fix i believe this can be closed.