search

sonatype-nexus-community / nexus-blobstore-google-cloud

Nexus Repository Manager Blobstore backed by Google Cloud Storage
https://help.sonatype.com/en/configuring-blob-stores.html#google-cloud-blob-store
Eclipse Public License 1.0
39 stars 16 forks source link

Add `getId()` to Descriptor #98

Closed Blacktiger closed 3 years ago

Blacktiger commented 3 years ago

This should allow the plugin to work correctly with the react blobstores

nblair commented 3 years ago

This appears to depend on changes not yet released in NXRM. It does not provide any compilation or test issues, @Blacktiger do you think there is any harm in me merging before the upstream changes are available? I'm inclined to merge this today, even though it doesn't completely solve the issue with the new Blobstore UI.

Blacktiger commented 3 years ago

I think that's fine, I'm giving it a try locally to ensure that it works with the new UI but since it doesn't add any backwards-incompatible changes I see no reason not to merge it. When we release the upstream changes we should consider adding the @Override annotation.