sonatype-nexus-community / nexus-repository-apk

Eclipse Public License 1.0
42 stars 24 forks source link

Update package version regex #32

Closed sjweixel closed 3 years ago

sjweixel commented 3 years ago

Update apk package version number regex to include letters and underscore so it works on with files like lua-socket-3.0_rc1_git20160306-r2.apk and ncurses-libs-6.1_p20200118-r4.apk

Update regex to work with apk package filenames in public Alpine repo that don't have the format X.X.X-rX ,

This pull request makes the following changes:

added a new regexp expression to be used in version() and name() cc @DarthHater @bhamail

sonatypecla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @sjweixel to sign the Sonatype Contributor License Agreement.

sjweixel commented 3 years ago

Please review.

bhamail commented 3 years ago

Would it be worth adding a (or altering an existing) unit test to show an example of the case this change is meant to cover? Maybe: ApkPathUtilsTest.java ? Up to you.