Some "improvements" / get it working on Nexus Repository 3.2.1-01

[DarthHater]

I've made a big amount of changes, some notable ones below:

• Code format, completely subjective but using the Sonatype code style (easier for me to read, sowwy) - https://github.com/sonatype/codestyle
• Implementing Handlers a bit more like how we've been doing it recently
  • See note below
• Adding in routes, easier to trace what matched what, etc...
  • This can be seen in AptRecipeSupport. Allows the Builders to be more explicit, easier to look at them and go "Ok it uses this route, and uses this handler"
• Adding in some helper classes (hopefully they actually help), AptPathUtils, AptRecipeSupport
  • I noticed assetPath getting used quite a few places, and some opportunity to add in some other helpers. This can likely grow in AptPathUtils
  • AptRecipeSupport is just to DRY out the Recipes themselves, and to put some new routes in (that both Hosted/Proxy can inherit if need be)
• Fixing up everything to use the state of Nexus Repository as of version 3.2.1-01
  • Self explanatory
• Change Transactional stuff to new style
  • We introduced new annotations for Transactions, should be self explanatory
• Implement AptHostedFacet
  • Style preference, just more akin to how we've been doing Hosted implementations
• Removed TempSupplier or whatever it was and started using TempBlob etc...
  • Newer way of doing THANGZ
• Made some pom changes to embed bouncycastle, makes some of the bundle loading a bit less painful

TODO:

• [X] Figure out OSGi stuff to make bouncycastle issue go away
• [x] Answer questions related to my whirlwind of activity

I don't quite understand everything you've done (because I don't understand apt-get more than likely), but I'm game to help if you can explain some things to me :)

[mpoindexter]

Hah, APT is a tricky beast, and a lot of it seems pretty poorly documented. I've found this super helpful https://wiki.debian.org/RepositoryFormat, but definitely spent a lot of time looking at in-the-wild repos to understand how apt deals with all of this stuff in practice.

[mpoindexter]

I've merged in all the changes to work with Nexus 3.2.1, and changed the formatting to Sonatype style, but I'm not so sure about the Handler stuff. What you have breaks snapshots for proxy repos as near as I can tell, so I don't want to merge that yet. I also don't think it's very clean to have classes called *Handler that aren't actually handlers , but just containers of handlers. I'll probably do something like you've done with the matchers in the future, but for now I'm going to leave that part out.

[DarthHater]

That's cool! I just switched it to that since we have been doing that internally (more an example than anything). Doing it the way you have been compacts all the logic into one place, which can be beneficial (in terms of looking at something and going WHAAAA?).