search

sonatype-nexus-community / nexus-repository-apt

A Nexus Repository 3 plugin that allows usage of apt repositories
Eclipse Public License 1.0
105 stars 50 forks source link

Hardcode LF as line separator to make this work in Windows #67

Closed gschizas closed 6 years ago

gschizas commented 6 years ago

This change allows the nexus apt repository plugin to run on Windows (IIS), by hardcoding LF as a line separator for the duration of the InRelease file creation.

This fixes #65, although it's a very hacky fix. I've tested it though and it does work.

sonatypecla[bot] commented 6 years ago

Thanks for the contribution! Before we can merge this, we need @gschizas to sign the Sonatype Contributor License Agreement.

mpoindexter commented 6 years ago

I wouldn't want to merge this as is. It's not thread safe: one thread could be monkeying with the system property while another thread uses it, so seems very dangerous. Think a patch we could merge would involve figuring out which code in the section you've surrounded with this actually uses this property and coming up with some way to influence its behavior without changing the system property.

gschizas commented 6 years ago

Fair enough - I knew the implementation was hacky. I'm closing this PR.