Closed fghamsary closed 2 years ago
fghamsary
commented
2 years ago As I didn't have time to check all the other changes, there are tests on Integration tests that are not passing because of configuration, if someone has some idea about the changes, any suggestion would be appritiated.
sjweixel
commented
2 years ago The config file looked the same as older config file that passed successfully. Could you try running the build-and-test again?
max464
commented
2 years ago We are also looking forward to this patch. Guys please repeat test.
shirimaasen
commented
2 years ago Can you re-run tests, please?
bhamail
commented
2 years ago I just noticed this PR. I had created PR #108, which is similar but instead uses a generic SearchFacet. You might want to try that approach instead of using ElasticSearchFacet. (I'm happy to use this PR instead if that change helps the tests to pass).
Well....it looks like the Integration Tests also fail on my PR, so need to dig further to find the cause...
bhamail
commented
2 years ago @fghamsary I finally found a fix for the IT failure (for the curious see: PR #108). I'm going to try adding the fixes from PR #108 into this branch and will merge this branch if all goes well.
bhamail
commented
2 years ago Thanks to Dawid for pointing out I should use org.sonatype.nexus.repository.search.index.SearchIndexFacet instead of SearchFacet. This change has been made on the main branch. see: 8bb9662b36afc79a36972883f25defb85b540fde
As explained in the https://github.com/sonatype-nexus-community/nexus-repository-composer/issues/103 the new version of Nexus have changed SearchFacet and we should use the new version ElasticSearchFacet instead.
This pull request makes the following changes:
It relates to the following issues: