Closed fghamsary closed 3 years ago
Thanks for the contribution! Unfortunately we can't verify if the committer(s), Farrokh Ghamsary fghamsary@v3d.fr Farrokh Ghamsary fghamsary@hotmail.com, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.
Can anybody check this please?
We'd be interested in this feature as well. :+1:
cc @allenhsieh
Can somebody please check this or propose another choice? We have used this version on our production, but I would like to have it in the original package.
@fghamsary tagging @jlstephens89 to take a gander!
Just wondering if anybody cares about this?
any feature is greatly appreciated on nexus composer as many people use it ;)
@fghamsary @jmalinens I echo that. Trying to get @jlstephens89 to jump in, his team and co own these formats more or less nowadays (@bhamail and I spend a lot less time on them than we used to). I think come April you'll see a bit more traction. If push comes to shove I'll come in and see if I can get this merged!
@jlstephens89 Any updates on this one? :)
@saitho No updates yet but as a team we're developing a program to get more eyes on these PRs. Watch this space :)
Can anybody with approval access, check this, I've been using my code in production for more than a year now, and everything is working as it should. I'd be glad to do more changes to my commits, or even add extra functionality to this repository and contribute more, but honestly when I see that a single change like this takes a whole year to be verified, I'm a little disappointed.
@jlstephens89 @allenhsieh @stefaanneyts Who can do something about it? Is there a problem with the code that I should correct?
Added possibility to add source tag in packages.json when uploading a package zip file.
This pull request makes the following changes:
This is the implementation we are using for the following feature request #55
Just a single test have been added and it might be better to add still more test.