Fix: dockerfile for 3.19+

sonatype-nexus-community / nexus-repository-composer

Composer support for the Nexus Repository Manager (work in progress!)

Eclipse Public License 1.0

214 stars 81 forks source link

Fix: dockerfile for 3.19+ #60

Closed tetram closed 3 years ago

tetram commented 4 years ago

The goal of this PR is to fix the dockerfile.

This pull request makes the following changes:

makes dockerfile compliant with the new project structure
makes dockerfile sed version 3.19.01-01 in pom

It relates to the following issue #s:

Fixes #49

Rakdos8 commented 4 years ago

Should NEXUS_VERSION values follow the sed one ?

tetram commented 4 years ago

It's the default build args, idk which version they should be pointing at... Maybe it would be nice to have them matching the default pom version.

I don't know if there is still anyone on this project giving guidelines^^

electrical commented 4 years ago

I've applied the proposed changes to my own build of it and works all fine now even with 3.20.1 build. Just have to make sure that the jar file is created for the specific nexus version.

taz77 commented 4 years ago

I made the changes missing here in PR #65

bhamail commented 3 years ago

I'm pretty sure this is fixed by commit: 5679dcb, so closing this PR. If I'm mistaken, please holler.