search

sonatype-nexus-community / nexus-repository-helm

At the Helm, Helm Yeah, v k8s
Eclipse Public License 1.0
97 stars 71 forks source link

Fixed inifinite while loop bug with helm chart tgz parser #100

Closed nibin closed 4 years ago

nibin commented 4 years ago

By default, the tgz parser expects the first item in the tgz is going to be the "module"/Chart.yaml file. This may not be enforced by all the tools who might generate a chart tgz file.

The fix is to continue the while loop and iterate to the next items in the tar to find the Chart.yaml file.

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Before we can merge this, we need @nibin to sign the Sonatype Contributor License Agreement.

nibin commented 4 years ago

I signed the cla. But dont know why it is not getting reflected here.

mlukaretkyi commented 4 years ago

Hi. Thanks for your updates, but we already have merged PR with fix this problem https://github.com/sonatype-nexus-community/nexus-repository-helm/pull/99 Is it ok for you? If ok please close this PR.

nibin commented 4 years ago

Thanks